Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the dataMoverTopic config param always being required #2572

Open
wants to merge 1 commit into
base: development/8.7
Choose a base branch
from
Open

Fix the dataMoverTopic config param always being required #2572

wants to merge 1 commit into from
+1 −5

Conversation

Kerkesni
Copy link
Contributor

@Kerkesni Kerkesni commented Nov 4, 2024

Extension configs are validated independently of each other, so validating the dataMoverTopic based on the supportedLifecycleRules param is not currently possible.

Issue: BB-619

@Kerkesni
Fix the dataMoverTopic config param always being required
004331a 
Extension configs are validated independently of each other, so
validating the dataMoverTopic based on the supportedLifecycleRules
param is not currently possible.

Issue: BB-619
@bert-e
Copy link
Contributor

bert-e commented Nov 4, 2024

Hello kerkesni,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@scality scality deleted a comment from bert-e Nov 4, 2024
@bert-e
Copy link
Contributor

bert-e commented Nov 4, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@codecov Codecov
Copy link

codecov bot commented Nov 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.41%. Comparing base (6694ca8) to head (004331a).

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
...tensions/replication/ReplicationConfigValidator.js 60.00% <ø> (ø)

... and 4 files with indirect coverage changes

Components Coverage Δ
Bucket Notification 66.66% <ø> (ø)
Core Library 75.36% <ø> (+0.22%) ⬆️
Ingestion 69.24% <ø> (ø)
Lifecycle 76.20% <ø> (ø)
Oplog Populator 82.95% <ø> (ø)
Replication 57.83% <ø> (+0.03%) ⬆️
Bucket Scanner 85.60% <ø> (ø) 
@@                 Coverage Diff                 @@
##           development/8.7    #2572      +/-   ##
===================================================
+ Coverage            70.31%   70.41%   +0.10%     
===================================================
  Files                  194      194              
  Lines                12997    12997              
===================================================
+ Hits                  9139     9152      +13     
+ Misses                3848     3835      -13     
  Partials                10       10
Flag Coverage Δ
api:retry 9.72% <ø> (ø)
api:routes 9.53% <ø> (ø)
bucket-scanner 85.60% <ø> (ø)
ingestion 12.45% <ø> (ø)
lib 7.50% <ø> (ø)
lifecycle 19.23% <ø> (ø)
notification 0.87% <ø> (ø)
replication 19.13% <ø> (+0.10%) ⬆️
unit 46.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kerkesni @bert-e